Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render commit IDs in commit message as HTML link #33308

Open
whmmm opened this issue Jan 17, 2025 · 6 comments
Open

Render commit IDs in commit message as HTML link #33308

whmmm opened this issue Jan 17, 2025 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@whmmm
Copy link

whmmm commented Jan 17, 2025

Description

see commit
https://gitea.com/whmmm/test-pr/commit/3c4f3ed82835d2b0796edff2ab64b38665ec551f

https://gitea.com/whmmm/test-pr/commit/98925bd76f9f03e3d021f90c4848a82ffa0ea83c

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Image

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None
@whmmm whmmm added the type/bug label Jan 17, 2025
@wxiaoguang
Copy link
Contributor

Could you elaborate what's the problem? What you expect? Whether it is a regression?

@whmmm
Copy link
Author

whmmm commented Jan 17, 2025

Could you elaborate what's the problem? What you expect? Whether it is a regression?

the ref 98925bd76f9f0
should display like:
ref 98925bd76f9f0

not pure text!

see https://docs.gitea.com/zh-cn/usage/automatically-linked-references
Image

@whmmm whmmm changed the title hash ref link no usable hash ref link not usable Jan 17, 2025
@wxiaoguang
Copy link
Contributor

当发布工单、合并请求或评论时，文本描述会被解析以查找引用。这些引用将显示为工单视图中的链接，并且在某些情况下会触发特定的“操作”。

It only works for Issue/PR/Comment, not for commit message.

@silverwind
Copy link
Member

Does the same work on GitHub/GitLab?

@wxiaoguang
Copy link
Contributor

Does the same work on GitHub/GitLab?

Actually, yes.

Image

@silverwind
Copy link
Member

Ok, then we should port it. It's often not clear which features are supposed to work in various places:

  • Comments
  • Issue/PR Title
  • Commit Message

@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 17, 2025
@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality and removed type/bug labels Jan 17, 2025
@wxiaoguang wxiaoguang changed the title hash ref link not usable Render commit IDs in commit message as HTML link Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@silverwind @wxiaoguang @whmmm