Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireit ignores npm's shell-script setting #832

Open
tao-cumplido opened this issue Aug 15, 2023 · 1 comment
Open

wireit ignores npm's shell-script setting #832

tao-cumplido opened this issue Aug 15, 2023 · 1 comment

Comments

@tao-cumplido
Copy link

tao-cumplido commented Aug 15, 2023

In #648 @aomarks already mentions that the shell-script setting isn't supported yet, but there was no explicit issue for it yet.

I use shell-script=/bin/zsh for some projects because ** globs work as expected instead of the default shell (at least on macOS).

For example when I run the following command with npm's default shell sh it only matches a subset of the expected match

> node -e "console.log(process.argv)" src/**/*.test.ts
[ '/path/to/my/project', 'src/test/a.test.ts', 'src/test/b.test.ts' ]
> 

but there's also a src/test/sub/a.test.ts which is not included in sh's expansion.

The actual command I noticed this with is tsx --test src/**/*.test.ts which uses tsx to run my tests written in TS with node's builtin test runner.

@tao-cumplido
Copy link
Author

Found a workaround: running the command through npx automatically picks up the npm settings.

npx -c 'tsx --test src/**/*.test.ts'

tao-cumplido added a commit to tao-cumplido/shigen that referenced this issue Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant