Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize fonts #51

Open
mattheu opened this issue Jul 6, 2016 · 2 comments
Open

Optimize fonts #51

mattheu opened this issue Jul 6, 2016 · 2 comments

Comments

@mattheu
Copy link
Member

mattheu commented Jul 6, 2016

We're loading 400KB of fonts which isn't great, but they do look nice. Could we make these non-blocking?
@mattheu
Copy link
Member Author

mattheu commented Jul 7, 2016

Actually they are already. Typekit allows us to pass async: true. It does cause a FOUC though.

@mattheu
Copy link
Member Author

mattheu commented Jul 14, 2016 •
edited
Loading

On handbook, we're setting opacity of text elements to 0 whilst fonts are loading, and fading in super quick on .wf-active

This is pretty nice I think, definitely less jarring. The downside is that on a slow connection the text will be unreadable whilst the font is loading, rather than readable but not the correct font. So not sure whether this should really be included in the core pattern library.

Another downside is that this will interfere with any other transitions set on these elements. Maybe we could do it, but without the fade in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattheu