Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No bullet pointes on legacy half and half [support request] #258

Open
atwellpub opened this issue Sep 28, 2015 · 9 comments
Open

No bullet pointes on legacy half and half [support request] #258

atwellpub opened this issue Sep 28, 2015 · 9 comments
Assignees

Comments

@atwellpub
Copy link
Member

Hey David,

We are about ready for a push, but I've not given the go yet mostly because of this issue right here I could use some help on:
#221

And in the meantime, know how to help this guy?:
http://support.inboundnow.com/support/topic/no-bullets-ok-sign-in-list-item/

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@DavidWells
Copy link
Member

Specific to that guys site: http://www.screencast.com/t/soKfqdHA3Ev

He is missing pseudo selectors

@atwellpub
Copy link
Member Author

Not sure how to address the support ticket atm. Will you take care of it?

@DavidWells
Copy link
Member

Do you know how to inline these styles differently? #221 (comment)

@DavidWells
Copy link
Member

Bullets are still broken http://www.screencast.com/t/CH6L0Z1O3e5

@atwellpub do you know another way to include these dynamic styles?

@atwellpub
Copy link
Member Author

Where are the styles coming from? The bullet points are restored if Inbound Pro is active, but I don't get why it would do it. But no matter what they are not checks.

This one baffles me.

@DavidWells
Copy link
Member

They are coming from here:
https://github.com/inboundnow/landing-pages/blob/master/shared/shortcodes/inbound-shortcodes.php#L531-L562

ACF normal strips out my inlined style tag from content and that breaks the
button styles

On Thu, Oct 15, 2015 at 4:04 PM, Hudson Atwell notifications@github.com
wrote:

Where are the styles coming from? The bullet points are restored if
Inbound Pro is active, but I don't get why it would do it. But no matter
what they are checks.

I really have no clue what is going on.


Reply to this email directly or view it on GitHub
#258 (comment)
.

@atwellpub
Copy link
Member Author

ACF is removing inline styling? What's the inline style tag?

@DavidWells
Copy link
Member

This code:
https://github.com/inboundnow/landing-pages/blob/master/shared/shortcodes/inbound-shortcodes.php#L532-L561

On Thu, Oct 15, 2015 at 5:37 PM, Hudson Atwell notifications@github.com
wrote:

ACF is removing inline styling? What's the inline style tag?


Reply to this email directly or view it on GitHub
#258 (comment)
.

@atwellpub
Copy link
Member Author

I think we could, when the shortcode is fired, hook an output function into the template footer:
https://github.com/inboundnow/landing-pages/blob/master/templates/svtle/index.php#L234-L235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants