WinLeave error when opening Go tests in new tab

[kossmar]

Neovim version (nvim -v | head -n1)

NVIM v0.7.2

Operating system/version

macOS 10.15.7

How to reproduce the issue

1. Install plugins:

• AsyncRun (https://github.com/skywind3000/asyncrun.vim)
• Taboo (https://github.com/gcmt/taboo.vim)\

2. Install golang

3. Add this function to init.vim

command Test call <SID>maketest()
function! s:maketest()
    if TabooTabName(tabpagenr()) == "maketest"
        AsyncRun -raw make test
        set filetype=text
    else
        AsyncRun -raw make test
        copen

        " move the error window to a new tab (see :help window-moving)
        exe "normal \<c-w>T" 
        TabooRename maketest
        set filetype=text
    endif
endfunction

4. call :Test in nvim

Expected behavior

Should open the tests in a new tab. And it does but I have to click through an error as specified below.

Actual behavior

Same as the expected behaviour but I have to click through this error.

Error detected while processing WinLeave Autocommands for "<buffer=3>":                                                                       
E5108: Error executing lua .../.config/nvim/plugged/nvim-bqf/lua/bqf/qfwin/session.lua:96: attempt to index local 'obj' (a nil value)         
stack traceback:                                                                                                                              
        .../.config/nvim/plugged/nvim-bqf/lua/bqf/qfwin/session.lua:96: in function 'saveWinView'                                             
        ...s/markoss/.config/nvim/plugged/nvim-bqf/lua/bqf/main.lua:103: in function 'saveWinView'  

I fixed it by adding a nil check to lua/bqf/qfwin/session.lua and this stopped the errors but I don't know if it might break something else...?

function QfSession:saveWinView(winid)
    if winid then
        local obj = self.pool[winid]
        local wv = utils.winCall(winid, fn.winsaveview)
        if obj ~= nil then
            obj:list():setWinView(wv)
        end
    end
end

[kevinhwang91]

The solution is not bad, please make a PR for it.

[Subjective]

I've also experienced this issue when toggling zen mode in the quickfix menu. Just opened a PR #120 that adds the nil check.