Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck broken for streaming #47

Open
damienlaine opened this issue Nov 22, 2024 · 0 comments · May be fixed by #59
Open

Healthcheck broken for streaming #47

damienlaine opened this issue Nov 22, 2024 · 0 comments · May be fixed by #59
Assignees
Labels

Comments

@damienlaine
Copy link
Member

damienlaine commented Nov 22, 2024

Description

When using SERVICE_MODE=websocket, the current implementation does not properly handle health checks, leading healthcheck fail streak in orchestrated deployments.


Current Behavior


Questions to Address

  1. Failback Implementation: Should we default to SERVICE_MODE=http and use it in combination with ENABLE_STREAMING to achieve streaming?
  2. Potential Drawbacks:
    • Could this approach introduce additional latency, system load, or other unexpected issues?

Expected Outcome

  • A robust health check mechanism that works seamlessly, regardless of the SERVICE_MODE.
  • Clear and unified documentation of expected behavior for each SERVICE_MODE.
@damienlaine damienlaine changed the title Healtcheck broken for streaming Healthcheck broken for streaming Nov 22, 2024
@damienlaine damienlaine moved this to Considering in LinTO Roadmap Nov 24, 2024
@AudranBert AudranBert self-assigned this Jan 6, 2025
AudranBert added a commit that referenced this issue Jan 7, 2025
Signed-off-by: AudranBert <bert.audran@gmail.com>
@AudranBert AudranBert linked a pull request Jan 7, 2025 that will close this issue
@AudranBert AudranBert linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Investigating
Development

Successfully merging a pull request may close this issue.

2 participants