From 55cf3f9ab22a0a2dc99e13a363bf464e3c552090 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Wed, 24 Apr 2024 08:04:07 +0200 Subject: [PATCH 1/2] CI: give the uploaded build artifacts an explicit name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This makes it easier to re-use the artifacts in other jobs, that e.g. publish them to pypi.org. Signed-off-by: Leonard Göhrs --- .github/workflows/build.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index a585d9a..1e8ce34 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -14,4 +14,5 @@ jobs: - run: make build - uses: actions/upload-artifact@v4 with: + name: dist path: dist From 43a167734982edcc07c08e331b2ee76e06dfd241 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Wed, 24 Apr 2024 08:05:46 +0200 Subject: [PATCH 2/2] CI: combine the qa and build stage into a single workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This does not have any immediate benefits but allows us to add a publish stage in the next step that depends on all the qa steps to complete successfully and use the artifacts generated by the build stage. Signed-off-by: Leonard Göhrs --- .../{build.yaml => check-and-build.yaml} | 18 ++++++++++++++++-- .github/workflows/qa.yaml | 18 ------------------ 2 files changed, 16 insertions(+), 20 deletions(-) rename .github/workflows/{build.yaml => check-and-build.yaml} (51%) delete mode 100644 .github/workflows/qa.yaml diff --git a/.github/workflows/build.yaml b/.github/workflows/check-and-build.yaml similarity index 51% rename from .github/workflows/build.yaml rename to .github/workflows/check-and-build.yaml index 1e8ce34..671dc5b 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/check-and-build.yaml @@ -1,10 +1,24 @@ -name: Build +name: Check and Build on: [push, pull_request] jobs: + codespell: + name: Codespell + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - run: make qa-codespell + + ruff: + name: Python Format and Lint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - run: make qa-ruff + build: - name: Source Distribution and Wheel + name: Build runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/qa.yaml b/.github/workflows/qa.yaml deleted file mode 100644 index 3987977..0000000 --- a/.github/workflows/qa.yaml +++ /dev/null @@ -1,18 +0,0 @@ -name: Quality Assurance - -on: [push, pull_request] - -jobs: - codespell: - name: Codespell - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - run: make qa-codespell - - ruff: - name: Python Format and Lint - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - run: make qa-ruff