-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM Lowering: support for cir.delete.array
#1285
Comments
cir.delete.array
@bcardosolopes assign me please |
@elhewaty Assigned to you. |
@elhewaty if this is your first contribution I recommend something a bit easier, but happy to review regardless. FWIW, @andykaylor is working on a similar issue #1286 here. |
@bcardosolopes, please recommend easier ones if possible, and I can delay this for later. |
@elhewaty any bug marked with One specific example: #589 I wouldn't be worried about people claiming the issues, if there hasn't been an update in a while (maybe more than a week?) they might not ever work on it anyways (from my experience so far), just post a comment that you are working on it and I'll assign it to you too. |
The following code fails to compile, which is reduced from libcxx code.
error
failed to legalize operation 'cir.delete.array' that was explicitly marked illegal
It is because we do not have a lowering prep implementation for
cir.delelte.array
, once we have it, we should be able to compile this. Not sure for this simple case, array cookie info is needed, but in general, it is needed for ABI loweringcir.delelte.array
.Create this issue so that we can track implementation as it would help ClangIR build libcxx
@ChuanqiXu9, keep you in the loop as you introduced
cir.delelte.array
in #1172, I understand that you guys don't need it to be lowered for analysis purpose, but you might be interested if someone in community picks it up.The text was updated successfully, but these errors were encountered: