Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more general names for user-customizable env variables #93

Open
critzo opened this issue Aug 25, 2021 · 0 comments
Open

Use more general names for user-customizable env variables #93

critzo opened this issue Aug 25, 2021 · 0 comments

Comments

@critzo
Copy link
Contributor

critzo commented Aug 25, 2021

Three env variables currently exist that are configurable by people using Murakami whose contents are used to name test results files, and are saved as metadata fields in the test results themselves:

  • MURAKAMI_SETTINGS_LOCATION
  • MURAKAMI_SETTINGS_NETWORK_TYPE
  • MURAKAMI_SETTINGS_CONNECTION_TYPE

Generalize these names across the application so users may logically define them based on their desired measurement focus. For example:

  • MURAKAMI_SETTINGS_DEVICE_ID
  • MURAKAMI_SETTINGS_DEVICE_METADATA1
  • MURAKAMI_SETTINGS_DEVICE_METADATA2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant