Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHDMAN: creating delta chd using parent chd with large size and small hunk will report error #13029

Open
crashGG opened this issue Nov 29, 2024 · 1 comment

Comments

@crashGG
Copy link

crashGG commented Nov 29, 2024

MAME version

0.271 , 0.272

System information

Win10 22h2 , AMD zen4 7840HS

Incorrect behaviour

In some cases,creating delta chd using parent chd with large size and small hunk will report error:

CHD error occurred: Hunk out of range
Error during compression: Hunk out of range
Fatal error occurred: 1

But when I changed chdman back to 0.270, the compression went smoothly.

Expected behaviour

compression went smoothly like 0.270

Steps to reproduce

1, specify the hunk size as 2048 to make chd file.
for example:
chdman createdvd -c zstd,flac,huff,lzma -hs 2048 -i "Soulcalibur III (Japan) (En,Ja) (v2.00).chd" -o "ori.chd"
2,Modify some data on the original iso (e.g. simply modify a few bytes). Then create a delta for the parent using the previous chd.
for example:
chdman createdvd -i "modded.iso" -op "ori.chd" -o "new.chd"

Additional details

I tested several larger iso that exhibited the problem:
Soulcalibur III (Japan) (En,Ja) (v2.00).iso
Berserk - Millennium Falcon-hen - Seima Senki no Shou (Japan).iso

@crashGG
Copy link
Author

crashGG commented Nov 29, 2024

In addition, the earliest problematic commit that can be traced back is this
4358422

@crashGG crashGG changed the title CHDMAN: function of creating chd using parent chd seems to be broken CHDMAN: In some cases,creating chd using parent chd will report error Nov 30, 2024
@crashGG crashGG changed the title CHDMAN: In some cases,creating chd using parent chd will report error CHDMAN: creating delta chd using parent chd with large size and small hunk will report error Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant