Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logging and storing of checkpoints #106

Open
martinwholtmon opened this issue Jun 11, 2024 · 0 comments
Open

update logging and storing of checkpoints #106

martinwholtmon opened this issue Jun 11, 2024 · 0 comments
Labels
wontfix This will not be worked on

Comments

@martinwholtmon
Copy link
Owner

Refactor the directory structure by utilizing self.version.

Instead of building the dataset/checkpoint name, create one folder and build the checkpoint and version naming based on that.
For example: {model}_f{frames}-{repeated_aug}/{sampling_method}/{dataset}/

Where:

  • checkpoint_dir = {model}_f{frames}-{repeated_aug}
  • name = {sampling_method}
  • version = {dataset}

To store the checkpoints/models correctly, reflect the change to the models as well.

To implement this change:

    checkpoint_dir = os.path.join(project_dir_path, "checkpoints", name)  # remove "checkpoints"

    ModelCheckpoint(
            dirpath=checkpoint_dir,  # update path to the log folder (including name and version)

    # Train
    trainer_params = {
        ....
        "logger": TensorBoardLogger(
            save_dir=checkpoint_dir, name="", version=""
        ),

https://github.com/Lightning-AI/pytorch-lightning/blob/3dcf7130c554f4511c756ccbb4e3a417103d595d/pytorch_lightning/loggers/tensorboard.py#L110-L119

@martinwholtmon martinwholtmon added maybe wontfix This will not be worked on and removed maybe labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant