Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_format_tag() not in lastgenre plugin anymore #5

Open
JOJ0 opened this issue Jan 25, 2025 · 0 comments
Open

_format_tag() not in lastgenre plugin anymore #5

JOJ0 opened this issue Jan 25, 2025 · 0 comments

Comments

@JOJ0
Copy link

JOJ0 commented Jan 25, 2025

Hi,
I'm very sorry, I broke your plugin because I patched out the lastgenre plugin's _format_tag() method in my recent rework. The "title casing" is now simply included in a larger function because it's not used elsewhere:

https://github.com/beetbox/beets/pull/4982/files#diff-f85204832b1e3e76cf854983f1f1773be9f7857d94656cbb3a0f2a0ae6431140R167-R177

What should we do about it? Bringing back the function in lastgenre is one option, the other is you implement it yourself. I see you have a method for it already:

def _format_genre(self, genre):
return self._lastgenre._format_tag(genre)

Sorry and appologize beforehand: I might have broken more things, it was quite a huge refactoring madness going on :-/ I'll report if I find more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant