Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include development container files #30

Open
MatthewCaseres opened this issue Nov 18, 2022 · 6 comments
Open

include development container files #30

MatthewCaseres opened this issue Nov 18, 2022 · 6 comments

Comments

@MatthewCaseres
Copy link

I would like to run your code in codespaces. I think there would need to be a devcontainer.json file pointing to your Dockerfile.

@mimoralea
Copy link
Owner

Can you create one? I'm not familiar with "codespaces".

@MatthewCaseres
Copy link
Author

MatthewCaseres commented Nov 21, 2022

If you click on "Code" where you would normally clone a repo in the GitHub UI it will give you the option to open the repo as a codespace. When you do this it will open an editor backed by a cloud instance. Even without configuring any codespace configuration files miniconda will be preinstalled. So all that is really needed is an environment.yml file which pins the dependencies.

The dockerfile which is included might not work if you rebuilt it, since the version of gym isn't specified. Some alternative to using the docker image provided would be really nice, I'm running out of storage on my computer and the image is very large.

Are there any dependencies which can't be managed by conda?

@mimoralea
Copy link
Owner

Can you modify the repo using the package versions on #29 and submit a pull request?

@MatthewCaseres
Copy link
Author

Yes I will try to create an environment.yml file and rerun the notebooks. Thank you for the printout of the versions.

@mimoralea
Copy link
Owner

To you for the report and the initiative.

@MatthewCaseres
Copy link
Author

MatthewCaseres commented Nov 23, 2022

You can open up a codespace on this branch - https://github.com/MatthewCaseres/gdrl/tree/codespace-matthewcaseres-legendary-space-happiness-rpgq4564pgxf57p5. The environment.yml file automatically installs into the base Conda environment.

Users can also open it locally using devcontainers feature of VS code.

The environment.yml file works up to chapter 4 but I still need to install PyTorch and some other things. I will submit the PR after running all of the notebooks (finishing the book). It may take a bit to work through the book, but I'm hopeful that this will work.

@MatthewCaseres MatthewCaseres changed the title include development container for GitHub Codespaces include development container files Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants