Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misuse of FreeRTOS task notifications as semaphores without give/take API #6

Open
4 of 5 tasks
mincrmatt12 opened this issue Jul 25, 2023 · 1 comment
Open
4 of 5 tasks

Comments

@mincrmatt12
Copy link
Owner

mincrmatt12 commented Jul 25, 2023

Right now there seems to be race conditions in places where we wait for a task to do something because I've somehow failed to notice that FreeRTOS has a separate semaphore API for task notifications (i.e. for waiting on notification state >= 0) that would solve a significant number of problems.

Fixes required in:

  • servicer (stm)
  • serial (esp)
    • to grabber
    • to dupm
  • matrix refresh (stm)
@mincrmatt12
Copy link
Owner Author

mincrmatt12 commented Jan 7, 2024

(apparently the FreeRTOS on the ESP8266 is too old to use them in esp-land, but the recent mutex should totally alleviate the problem) edit: this is apparently not true, I was being fooled by autocomplete (still the explicit mutexes completely alleviate the racing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant