-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IPv6 litteral addresses #23
Comments
I think @mor1 made some progress on an ipv6 parser in ocaml... |
somewhere. wasn't complete though. can't recall if it was in the repo or not. i'll have a look... |
related to mirage/ocaml-ipaddr#9 |
I thought a pretty minimal regex parser for this made it in a while ago... This will happen after it gets into ocaml-ipaddr which will take it to 2.0. Then, ocaml-ipaddr will become a dep of ocaml-uri when The Coming Reckoning finally fixes the |
This works pretty well with Ipaddr atm; do we really need it in URI?
|
I think there is some place for a type that sums addresses and host names. End users shouldn't (necessarily) have to consider that the host string that they get back may not need name resolution. I was imagining something like: type host = Ipaddr of Ipaddr.t | Host of string
val host : t -> host option
val host_string : t -> string option where |
Did 'Uri' regress this behaviour? The example from above #23 (comment) no longer works, it doesn't parse RFC conforming IPv6 addresses anymore:
|
http://[::1] can be transformed from and to string for example.
The text was updated successfully, but these errors were encountered: