Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Bookmarks Evolution] - Unable to remove bookmarks from shortcuts through context menu #24449

Open
data-sync-user opened this issue Jan 30, 2025 · 3 comments

Comments

@data-sync-user
Copy link
Collaborator

Steps to reproduce

  1. Fresh install FF. Add a bookmark.
  2. Navigate to the "Bookmarks" section.
  3. Long tap on the newly saved bookmark and choose to add it to shortcuts.
  4. Long tap again on the newly saved bookmark to remove it from shortcuts.

Expected behavior
Remove from shortcuts option is displayed in the context menu.

Actual behavior
Add to shortcuts is displayed instead of remove from shortcuts, although the link is already added to shortcuts.

Device & build information

  • Device: iPad Air 11' (18.2)
  • Build version: v9000 (50315)

┆Issue is synchronized with this Jira Bug

@data-sync-user
Copy link
Collaborator Author

➤ Matt Lichtenstein commented:

Michael Verdi I don’t recall seeing this in the mockups. what is the expected behavior here?

@data-sync-user
Copy link
Collaborator Author

➤ Michael Verdi commented:

We didn’t design this as part of this project. If we want to keep this option, the correct behavior should be to change the menu entry to Remove from Shortcuts. This bug exists in the current bookmark system.

@data-sync-user
Copy link
Collaborator Author

➤ Matt Lichtenstein commented:

I think fixing it makes sense to fix for both, especially since the logic is shared between legacy and redesign, it would be more effort to fix it only for the redesign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant