Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ActionToast usage in RemoteTabsTableViewController with ButtonToast. #24457

Open
lmarceau opened this issue Jan 30, 2025 · 0 comments
Open
Labels
Contributor OK This is a good issue for contributors interested in helping the project

Comments

@lmarceau
Copy link
Contributor

lmarceau commented Jan 30, 2025

📄 Context

We have different Toast classes in the app. One of those is ActionToast which is only used in two places in the application at the moment. ActionToast is very similar to ButtonToast, so we should be able to replace ActionToast usage with the ButtonToast class. With recent changes to Toast, having extra classes to support makes it harder to make changes and have a unified design. Let's remove ActionToast while its not used in many places.

✏ Requirements

  1. Replace ActionToast usage in RemoteTabsTableViewController with ButtonToast.
  2. If there's some blockers/reasons why ButtonToast cannot be used there, please let us know in comments.
  3. Put screenshots of before/after in your PR in light and dark mode.

Note: If ActionToast is not used anywhere else anymore, you can remove that class from the codebase.

Relates to task #24458

ℹ️ Reference Person

@lmarceau

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor OK This is a good issue for contributors interested in helping the project
Projects
None yet
Development

No branches or pull requests

1 participant