Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow not making gradient for acquisition functions #313

Open
SRFU-NN opened this issue Jan 16, 2025 · 0 comments
Open

Allow not making gradient for acquisition functions #313

SRFU-NN opened this issue Jan 16, 2025 · 0 comments

Comments

@SRFU-NN
Copy link
Collaborator

SRFU-NN commented Jan 16, 2025

Suggestion for solution to be implemented:

Change acquisition functions so they always return a tuple, with the second entry (grad) being None if they don't calculate gradient.
If grad from acquisition function is None, get scipy to estimate gradients.

#221 closed
See #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SRFU-NN