Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accept . character in proxy path escape pattern #150

Open
testinfected opened this issue Aug 20, 2024 · 0 comments
Open

feat: accept . character in proxy path escape pattern #150

testinfected opened this issue Aug 20, 2024 · 0 comments

Comments

@testinfected
Copy link

Currently proxy path pattern mes only accept 0-9, a-z, A-Z and - in names which prevents using a domain name as a cluster name.

By also accepting the . character, we can use cluster names such as cluster.location without losing the escapting of the dryRun query parameter.
testinfected pushed a commit to testinfected/cluster-gateway that referenced this issue Aug 20, 2024
feat: allow . in proxy path escape pattern
b592fc8 
Add the `.` character to the proxy path escape pattern so that
we can use e.g. domain names as cluster names without
breaking the query parameters escaping.

See oam-dev#150
This was referenced Aug 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@testinfected