-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cuPQC ML-KEM upstream away from personal repo #2053
Comments
That's my clear preference: It makes clear whose code this is and who has the responsibility (and capability) to update the code with future updates to the NVIDIA library or any potential breakages in cuPQC becoming visible only in
What do you understand by "local upstream"? Either something is external (copied from a site where there is support and maintenance) or there is code internal to |
The thought was that this and similar upstreams could be stored locally in a dir, say scripts/copy_from_upstream/local, with maintainence responsibility clearly documented in the CODEOWNERS file. @baentsch do you think that is sufficient deliniation of maintenance responsibility? The reason I'd suggested this instead of a Nvidia repo is because Nvidia has a single monolithic repository for all their open source projects (is that correct @stevenireeves?). I'd assumed that would mean we may have to pull a repo of some significant size to use copy_from_upstream.py in the expected way; I have since then learned it is possible to do a "sparse git checkout" which would allow use to copy only specified directories. I shall look more into this. |
The cuPQC ML-KEM upstream added by #2044 resides in a personal GitHub repo. Either move this upstream to a Nvidia repo or update copy_from_upstream.py to accomodate a new class of local upstream.
The text was updated successfully, but these errors were encountered: