Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on main branch failing after #2044 merge #2056

Open
praveksharma opened this issue Jan 28, 2025 · 1 comment
Open

CI on main branch failing after #2044 merge #2056

praveksharma opened this issue Jan 28, 2025 · 1 comment
Assignees
Labels
bug Something isn't working; high priority to fix

Comments

@praveksharma
Copy link
Member

praveksharma commented Jan 28, 2025

The new CI test to test cuPQC builds introduced by #2044 is failing on the main branch. This problem is occuring because CMake can not find NVCC, it first occured when working on #2044; although it was resolved and CI was green before the merge that test is failing again now. I shall work on getting this fixed.

@baentsch
Copy link
Member

The error is a simple one: There's a hard-coded compiler path:

run: mkdir build && cd build && cuPQC_DIR=/cupqc/cupqc/cupqc-pkg-0.2.0/cmake/ CUDACXX=/usr/local/cuda-12.6/bin/nvcc cmake -GNinja -DOQS_USE_CUPQC=ON -DCMAKE_CUDA_ARCHITECTURES=80 .. && cmake -LA -N ..
that's out of sync with the CI image.

But in looking at the issue, I noticed that the default CI image (openquantumsafe/ci-ubuntu-latest:latest) grew to > 14GB. This IMO is out of sync with our goal of being "environmentally friendly": Just the load of this huge image takes 1-2 minutes, i.e., 30% to 70% of the complete CI runtime of several tests (also making me wonder why there's apparently no caching?).

May I thus suggest splitting out a (arbitrarily large) separate image for "thorough" testing (say once a week or only at release) and revert the main "workhorse image" to something more efficient? In other words, as part of the fix, may I suggest placing testing for cuPQC somewhere else in the CI setup (and use a separate image)?

@baentsch baentsch added the bug Something isn't working; high priority to fix label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working; high priority to fix
Projects
Status: Todo
Development

No branches or pull requests

2 participants