Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensslconf.h not used #2057

Open
bencemali opened this issue Jan 28, 2025 · 2 comments
Open

opensslconf.h not used #2057

bencemali opened this issue Jan 28, 2025 · 2 comments
Labels
bug Something isn't working; high priority to fix

Comments

@bencemali
Copy link
Contributor

Liboqs uses openssl flags like OPENSSL_NO_STDIO, but does not use openssl's opensslconf.h used for publicizing these flags. In src/common/common.h or other files something like this could be added:

#ifdef OQS_USE_OPENSSL
#include <openssl/opensslconf.h>
#endif
@baentsch
Copy link
Member

That's an interesting and apparently --from a code integrity/testing perspective unfortunately-- accurate observation: Thanks, @bencemali for making us aware of this!

Would you care to contribute this fix via PR? Are there other instances of such "never true" code paths? Looks like a (different) repeat of https://github.com/orgs/open-quantum-safe/discussions/2038.

@baentsch baentsch added the bug Something isn't working; high priority to fix label Jan 28, 2025
@bencemali
Copy link
Contributor Author

@baentsch I can look into it a bit further then open a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working; high priority to fix
Projects
Status: Todo
Development

No branches or pull requests

2 participants