Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending .onion link causes Session crash #3267

Open
3 tasks done
as-muncher opened this issue Jan 4, 2025 · 11 comments
Open
3 tasks done

Sending .onion link causes Session crash #3267

as-muncher opened this issue Jan 4, 2025 · 11 comments
Labels
bug Something isn't working

Comments

@as-muncher
Copy link

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When trying to paste a link into the text field, an .onion link, Session freezes, nothing can be typed into the text field, when I click x in the top right to kill the application, and then open up Session again, my password is not asked for. I have to terminate all the session processes, that entire tree and then open Session again.

Expected Behavior

A link should paste.. At least Session shouldn't freeze. I wish I could post the version of Session for desktop I'm using... that information should show when you press the gear icon. Oh... it does.. but in dark mode.. it's so hard to see when your screen is dimmed. v.1.14.5

Steps To Reproduce

windows 11 x64, run Session with a password. Copy an .onion link from a text file and right click in the text field, the select Paste. Then click in the text field area and try to type. Open a different window, then open your session window again, and you'll see that it's not even displaying. click the x in session. Then open it again, and it won't ask you for a password. To fix: terminate all the Session threads using Process Explorer or whatever you have.

Desktop Version

1.14.5

Anything else?

No response

@as-muncher as-muncher added the bug Something isn't working label Jan 4, 2025
@KeeJef
Copy link
Collaborator

KeeJef commented Jan 6, 2025

I tried to reproduce with the following .onion links in note to self and was unable to reproduce the issue, did you have link previews turned on or off? Was it in a specific type of chat? Closed group, 1-1 or Community? Do you have a log file you can share from Session?

http://haystak5njsmn2hqkewecpaxetahtwhsbsa64jom2k22z5afxhnpxfid.onion/
http://zqktlwiuavvvqqt4ybvgvi7tyo4hjl5xgfuvpdf6otjiycgwqbym2qad.onion

@KeeJef KeeJef changed the title [BUG] <title> Sending .onion link causes Session crash Jan 6, 2025
@as-muncher
Copy link
Author

@KeeJef, try an onion link that has a question mark in the URL and/or an equal sign

@KeeJef
Copy link
Collaborator

KeeJef commented Jan 9, 2025

Still unable to reproduce with that link, do you have link previews turned on or off? Do you have any local SOCKS proxies which would be resolving these .onion addresses on your system? Perhaps you could provide some logs from your device (Settings -> Help -> Export Logs) or a screen recording reproducing the issue?

@as-muncher
Copy link
Author

I have link previews off.. let me see about helping you out with more information.

@as-muncher
Copy link
Author

as-muncher commented Jan 10, 2025

But how can I post any more information when Session freezes completely? Ok I see what the problem is. If I right-click and copy this link from here on github then post into Session, the link will paste. However, if I copy your test link into Wordpad, and then from there copy it, then paste into Session, it freezes. So I'm not sure if there are special characters or what going on.

@KeeJef
Copy link
Collaborator

KeeJef commented Jan 10, 2025

If you run the Session executable from the terminal/command line, logs should print to the terminal, so even if Session crashes, logs should still be visible, try that.

The Session.exe should be at the following path C:\Users\YOURCOMPUTERUSERNAME\AppData\Local\Programs\Session , replacing YOURCOMPUTERUSERNAME with your computers username.

@as-muncher
Copy link
Author

@KeeJef Try it for yourself. Copy the link above, your test link that you provided, paste it into Wordpad or even LibreOffice Writer, then select the lines containing that link (don't highlight the link perfectly from start to finish), and then paste it into Session. When I turned on showing hidden symbols in LibreOffice, I could see that there's a paragraph marker or some similar symbol, and so when there is a space or some other symbol pasted into Session like that, it freezes. There are still 6 processes running, using CPU, but the GUI is not responsive.

@KeeJef
Copy link
Collaborator

KeeJef commented Jan 13, 2025

Tried as per your suggestion, copied this link into OpenOffice http://zqktlwkgmv5ipqnik77wyetb74bg6gtlwifjntd3anvprue7qqzaqlid.onion/wiki/index.php?title=Main_Page , then copied the lines around the link, including the link from OpenOffice, right click paste that into Session text box in Note to Self. No freezing in my Session Desktop client (1.14.5) from what i can see. Tried Wordpad too

@as-muncher
Copy link
Author

@KeeJef the logs don't give time in local time... so I wanted to delete some unnecessary older stuff... but let me see what I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants