Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default-default state name from "Invalid" to something else for the state setup helper #191

Open
ZLLentz opened this issue Aug 23, 2023 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Aug 23, 2023

Current Behavior

Debug can be confusing since the default state name resets to "Invalid" after each call, so the sName looks like it's being called with value "Invalid" in online mode, causing some confusion and generating red herrings

Expected Behavior

Debug should be less confusing
The default default is essentially irrelevant here, functionally: you only call this FB if you want to set up a real state with some name.

Context / environment

Encountered while helping debug on tmo motion

Steps to Reproduce (for bugs)

  1. look at tmo-motion sp1k4 program in online mode

Suggested Solution

Change it to empty string, "unnamed", or something else less scary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant