Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise if scripts are used instead of entrypoints #12

Open
klauer opened this issue Feb 23, 2023 · 1 comment
Open

Raise if scripts are used instead of entrypoints #12

klauer opened this issue Feb 23, 2023 · 1 comment

Comments

@klauer
Copy link
Contributor

klauer commented Feb 23, 2023

I ran into this in the elog migration too, though there it was a raw python file being referenced instead of an entrypoint. As a result the conversion didn't work, but that's somewhat out of scope here.

In my case this error helped alert me to the error, and with this the script would have
just disappeared. I'm not sure there's a good way around this and I don't think it's a common case.

Originally posted by @tangkong in #11 (review)

@tangkong
Copy link
Contributor

Previous setup.py invocation: https://github.com/pcdshub/elog/blob/0f5e6d6cf75018352ec5c52302c4642b50a50052/setup.py#L15

Working (I believe) pyproject.toml invocation:

  • move the script inside the package
  •   [project.scripts]
      LogBookPost = "elog.scripts.LogBookPost:main"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants