Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quality of discord score embeds from official links #11678

Open
peppy opened this issue Nov 22, 2024 · 2 comments
Open

Improve quality of discord score embeds from official links #11678

peppy opened this issue Nov 22, 2024 · 2 comments

Comments

@peppy
Copy link
Member

peppy commented Nov 22, 2024

Giving this a bit of attention would mean that a lot of people could stop using third party bots to achieve the same results.

Discussed in ppy/osu#30685

Originally posted by RadioactivePeaches November 16, 2024
I share my scores with friends on discord frequently, and I usually just take a screenshot of the end screen and sometimes I use the share replay feature on lazer. But when I share the actual replay link my friends have to actually click the link to see any details. It would be great if instead of a description of osu, score details are in the embed instead.

This way people you share to can see the basic information of the play such as 100s, misses, score, acc, etc and then if they want to download and watch the actual replay they can click the link. Or the embed could contain an image similar to how you screenshot the end screen or just the contents of the page itself, since its minimal anyway.

image
This is what it looks like right now, but it would be cool if it looked something like what a lot of osu! bots provide instead:
image

@peppy peppy transferred this issue from ppy/osu Nov 22, 2024
@notbakaneko notbakaneko self-assigned this Nov 22, 2024
@notbakaneko
Copy link
Collaborator

I thought we had an opengraph provider for this already but I guess not 🤔

@LBlend
Copy link
Contributor

LBlend commented Jan 20, 2025

This is just me rambling. Don't waste your time reading this unless you want to.

I know I shouldn't have proceeded with this as it has already been assigned to a person, but I took a look at it anyway. There are several considerations to take into account if we want the most amount of information display in a neat manner.

First of all it's pretty limited what you can do with opengraph as opposed to say using native discord embeds. Basic text formatting like bold text are missing, making it hard to display things neatly. Not to mention it should look good on other websites as well, though this should in theory not be our concern.

You would also need to make a separate provider for each game mode unless you want to stick to bare minimum information about the score. Some information about the map itself would also be nice, which would increase the complexity a bit. This is not really a problem but I guess it's good to know.

Finally, there are no synthetic scores on the dev instance, making it hard to test. There's probably a way to create scores but it requires effort, of which could be put into doing dev work instead. Potential dev QOL improvement?

Anyway as I mentioned this task has already been assigned so I will not proceed on it. I thought I'd just comment my "findings" here in hopes of bumping this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants