Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent public channels with identical names from being created #6

Open
nesium opened this issue Nov 16, 2023 · 0 comments
Open

Prevent public channels with identical names from being created #6

nesium opened this issue Nov 16, 2023 · 0 comments

Comments

@nesium
Copy link

nesium commented Nov 16, 2023

Public Channel names should be unique, i.e. it would be weird to have two #general channels in the same company.

Before creating a public channel, the core-lib currently loads all MUC rooms, checks if a room with the given name already exists and throws an error in that case. The same is true when our user tries to rename a public channel. This logic is prone to race conditions, i.e. client 1 and client 2 check for duplicates with no duplicate being found then create a room with the same name. The logic is also not in effect when using another XMPP client, so uniqueness could only be enforced server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant