Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestRawMultiFEMINOSToSignalProcess exits when processing the last event of a stopped run .aqs file #135

Closed
AlvaroEzq opened this issue May 28, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@AlvaroEzq
Copy link
Contributor

We have being dealing with this issue where this process TRestRawMultiFEMINOSToSignalProcess exits when processing the last event of a stopped (with ctrl+C) run .aqs file and then, the output file cannot be further processed. This is a very annoying problem because is very common to stop the run due to a trip or whatever but still want to analyze the events.

I found that the line causing this issue is this one:


And changing it to return nullptr; works for me to solve this specific case.

I am not familiar with this kind of processes so I am not sure if this change would break in other scenarios...

@AlvaroEzq AlvaroEzq added bug Something isn't working help wanted Extra attention is needed labels May 28, 2024
@jgalan
Copy link
Member

jgalan commented May 30, 2024

At first sight it looks as a good solution, there is the TREX-DM validation pipeline that uses this process, so in case that this line causes troubles the validation might fail.

https://github.com/rest-for-physics/framework/actions/runs/9300876077/job/25598296562

Just push a PR with this change and check if passes the pipeline.

@AlvaroEzq
Copy link
Contributor Author

Solved in PR#136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants