Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock item component is wrong #1129

Open
spring-dependency-management opened this issue Jan 31, 2025 · 0 comments
Open

Lock item component is wrong #1129

spring-dependency-management opened this issue Jan 31, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@spring-dependency-management
Copy link
Contributor

Packet events has the lock item component as just a string code, it is more complex, so setting it causes client to crash

packetevents:

public class ItemLock {

    private String code;

    public ItemLock(String code) {
        this.code = code;
    }

in reality it holds an item predicate:

public record LockCode(ItemPredicate predicate) {

Fix: change string code to item predicate

@spring-dependency-management spring-dependency-management added the bug Something isn't working label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant