Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.is_valid_client_config needs additional checks for Client_static #99

Open
reynir opened this issue Oct 6, 2023 · 3 comments
Open

Comments

@reynir
Copy link
Contributor

reynir commented Oct 6, 2023

If I remember correctly the engine will query for Ifconfig, Route_gateway and maybe more. Maybe it is a bad config, but I was missing route-gateway (I did not intend to route the traffic outside the virtual private network).

@hannesm
Copy link
Contributor

hannesm commented Oct 6, 2023

Aren't some of these options only later transported (by the server) via the PUSH_NOTIFY?

@reynir
Copy link
Contributor Author

reynir commented Oct 6, 2023

Hmm, true. These are usually pushed by the server (but can be configured by the client). Maybe the way forward would be to not expect Ifconfig and Route_gateway to be present, and maybe the latter only when the former is present.

@hannesm
Copy link
Contributor

hannesm commented Jun 17, 2024

Turns out, for the static client, these should indeed be present -- and should be checked by the is_valid_client_config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants