Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] vylepseni prace s Promises #66

Open
2 tasks
rodlukas opened this issue Feb 19, 2019 · 3 comments
Open
2 tasks

[js] vylepseni prace s Promises #66

rodlukas opened this issue Feb 19, 2019 · 3 comments
Assignees
@rodlukas
Labels
🐜 bug něco nefunguje ✏️ enhancement vylepšení stávající funkce ⏰ waiting

Comments

@rodlukas
Copy link
Owner

rodlukas commented Feb 19, 2019 •
edited
Loading

resit se bude az s prichodem Suspense for Data Fetching - viz #59

  • pokud se nepovede pozadavek (napr. casovy konflikt), v safari na macos/ios je unhandled rejection, coz dava smysl, protoze Promise je skutecne rejected a zadne catch ho neodchytne, v ostatnich prohlizecich se nedeje, ale melo by byt osetreno, protoze neni jediny duvod, aby toto nezacly reportovat i ostatni prohlizece (i do Sentry)
  • provadi se setState na unmounted komponentach, promise ktery se vyresil, ale uz se zmeny nemohou projevit, by se mel korektne zrusit, na to je mnoho antipatternu, je potreba to vymyslet rozumne (hooky?)
@rodlukas rodlukas added the 🐜 bug něco nefunguje label Feb 19, 2019
@rodlukas rodlukas self-assigned this Feb 19, 2019
@rodlukas rodlukas changed the title [js] unhandled rejection v safari [js] vylepseni prace s Promises May 4, 2019
@rodlukas rodlukas added the ✏️ enhancement vylepšení stávající funkce label May 4, 2019
@rodlukas rodlukas added this to the vyřešit načítání milestone Jun 17, 2019
@sentry-io
Copy link

sentry-io bot commented Jun 20, 2019

Sentry issue: UP-ADMIN-3Q

@sentry-io
Copy link

sentry-io bot commented Jun 20, 2019

Sentry issue: UP-ADMIN-3R

@rodlukas rodlukas removed this from the vyřešit načítání milestone Aug 31, 2019
@sentry-io
Copy link

sentry-io bot commented Sep 17, 2019

Sentry issue: UP-ADMIN-4G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodlukas rodlukas

Labels
🐜 bug něco nefunguje ✏️ enhancement vylepšení stávající funkce ⏰ waiting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rodlukas