diff --git a/.github/workflows/e2e-linux.yaml b/.github/workflows/e2e-linux.yaml index 688e1e2c1..5646f76b1 100644 --- a/.github/workflows/e2e-linux.yaml +++ b/.github/workflows/e2e-linux.yaml @@ -154,7 +154,7 @@ jobs: steps: - name: configure aws credentials uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2 - if: >- + if: | ${{ needs.test.outputs.has_creds == 'true' && ((startsWith(inputs.os, 'amazon') && inputs.version != '2' )) @@ -190,14 +190,14 @@ jobs: }} run: ls -R linux-${{ inputs.version }}-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports - name: Check and upload e2e tests reports to s3 bucket - if: >- - ${{ needs.test.outputs.has_creds == 'true' - && ((startsWith(inputs.os, 'amazon') - && inputs.version != '2' )) + if: | + needs.test.outputs.has_creds == 'true' + && ${{ ((startsWith(inputs.os, 'amazon') + && inputs.version != '2' )) }} && github.event_name == 'pull_request' && github.event.action == 'closed' && github.event.pull_request.merged == true - }} + run: | VM_REPORT="${{ github.workspace }}/linux-${{ inputs.version }}-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports/${{ github.run_id }}-${{ github.run_attempt }}-e2e-vm-report.json" CONTAINER_REPORT="${{ github.workspace }}/linux-${{ inputs.version }}-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports/${{ github.run_id }}-${{ github.run_attempt }}-e2e-container-report.json" diff --git a/.github/workflows/e2e-macos.yaml b/.github/workflows/e2e-macos.yaml index 174fdaa5f..d3e49d400 100644 --- a/.github/workflows/e2e-macos.yaml +++ b/.github/workflows/e2e-macos.yaml @@ -141,7 +141,7 @@ jobs: if: github.event_name == 'pull_request' && github.event.action == 'closed' && github.event.pull_request.merged == true run: ls -R macos-${{ inputs.version }}-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports - name: Check and upload e2e tests reports to s3 bucket - if: >- + if: | ${{ needs.test.outputs.has_creds == 'true' && github.event_name == 'pull_request' && github.event.action == 'closed' diff --git a/.github/workflows/e2e-windows.yaml b/.github/workflows/e2e-windows.yaml index 4e859419c..f685f6b02 100644 --- a/.github/workflows/e2e-windows.yaml +++ b/.github/workflows/e2e-windows.yaml @@ -126,27 +126,24 @@ jobs: - name: Set output variables id: vars run: | - $has_creds="${{ github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' && - github.event_name == 'pull_request' && - github.event.action == 'closed' && - github.event.pull_request.merged == true}}" + $has_creds="${{ github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}" echo "has_creds=$has_creds" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append exit 0 # if $has_creds is false, powershell will exit with code 1 and this step will fail - name: configure aws credentials uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2 - if: ${{ env.has_creds == 'true' }} + if: env.has_creds == 'true' with: role-to-assume: ${{ secrets.ROLE }} role-session-name: credhelper-test aws-region: ${{ secrets.REGION }} - name: download artifacts uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.08 - if: ${{ env.has_creds == 'true' }} + if: env.has_creds == 'true' with: name: windows-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports path: windows-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports - name: Check and upload e2e tests reports to s3 bucket - if: ${{ env.has_creds == 'true' }} + if: env.has_creds == 'true' run: | $env:VM_REPORT = "${{ github.workspace }}\windows-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports\${{ github.run_id }}-${{ github.run_attempt }}-e2e-vm-report.json" $env:CONTAINER_REPORT = "${{ github.workspace }}\windows-${{ inputs.test-command }}-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports\${{ github.run_id }}-${{ github.run_attempt }}-e2e-container-report.json"