Replies: 1 comment
-
Let's stick with "Callbacks" are a broader concept than "hooks", since the latter plays part in actualizing the former. A "callback" is the action of the protocol calling back the "hook" implemented by third-party developers. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In a recent internal discussion on Slack, @maxdesalle was confused about what exactly "callbacks" mean in the context of Sablier V2:
@andreivladbrg and I have been using the terms "hooks" and "callbacks" interchangeably. These terms refer to our V2 contracts' capacity to notify the senders and the recipients of streams when the other party makes a move (cancellation, renouncement, or withdrawal). For the callback to be triggered, the sender and the recipient must be a contract that implements one of the two following interfaces:
ISablierV2LockupRecipient
ISablierV2LockupSender
The question is: should we rename the
hooks
directory tocallbacks
? Alternatively, should we keephooks
but never refer to them as callbacks in our public outreach (marketing, documentation website, etc.)?Both sound okay, but I see the value in having just one way we refer to this functionality.
Related:
Beta Was this translation helpful? Give feedback.
All reactions