Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align query context handling with database/sql practices #14

Open
murfffi opened this issue Jan 7, 2025 · 0 comments
Open

fix: align query context handling with database/sql practices #14

murfffi opened this issue Jan 7, 2025 · 0 comments

Comments

@murfffi
Copy link
Member

murfffi commented Jan 7, 2025

There are at least two places where the context handing in the QueryContext path seems suspicious.
Both fetchfn and closefn are tied to the original QueryContext which seems inconsistent with the wrapper code in database/sql (sql.go). Especially, for closefn, this likely means that an query operation can't be closed if the parent context is cancelled.

Review how other more popular drivers handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant