From efc0caddc355de3adbe6bf3935b7f1f3c5973f9d Mon Sep 17 00:00:00 2001
From: Simon Podlipsky <simon@podlipsky.net>
Date: Thu, 30 Jan 2025 12:07:54 +0100
Subject: [PATCH] refactor(param-value-converter-registry): wider date
 converters input type and throw exception (#287)

---
 src/Param/ParamValueConverterRegistry.php     | 55 ++++++++++++++-----
 .../Param/ParamValueConverterRegistryTest.php |  8 ++-
 2 files changed, 47 insertions(+), 16 deletions(-)

diff --git a/src/Param/ParamValueConverterRegistry.php b/src/Param/ParamValueConverterRegistry.php
index 8acebe5..190629f 100644
--- a/src/Param/ParamValueConverterRegistry.php
+++ b/src/Param/ParamValueConverterRegistry.php
@@ -8,6 +8,7 @@
 use DateTimeInterface;
 use Psr\Http\Message\StreamInterface;
 use SimPod\ClickHouseClient\Exception\UnsupportedParamType;
+use SimPod\ClickHouseClient\Exception\UnsupportedParamValue;
 use SimPod\ClickHouseClient\Sql\Escaper;
 use SimPod\ClickHouseClient\Sql\Type;
 
@@ -18,6 +19,8 @@
 use function implode;
 use function in_array;
 use function is_array;
+use function is_float;
+use function is_int;
 use function is_string;
 use function json_encode;
 use function sprintf;
@@ -26,13 +29,12 @@
 use function trim;
 
 /**
- * @phpstan-type Converter = Closure(mixed, Type|string|null, bool):(StreamInterface|string)
- * @phpstan-type ConverterRegistry = array<string, Converter>
+ * @phpstan-type Converter Closure(mixed, Type|string|null, bool):(StreamInterface|string)
+ * @phpstan-type ConverterRegistry array<string, Converter>
  */
 final class ParamValueConverterRegistry
 {
-    /** @var list<string> */
-    private static array $caseInsensitiveTypes = [
+    private const CaseInsensitiveTypes = [
         'bool',
         'date',
         'date32',
@@ -94,9 +96,17 @@ public function __construct(array $registry = [])
             'date32' => self::dateConverter(),
             'datetime' => self::dateTimeConverter(),
             'datetime32' => self::dateTimeConverter(),
-            'datetime64' => static fn (DateTimeInterface|string|int|float $value) => $value instanceof DateTimeInterface
-                ? $value->format('U.u')
-                : $value,
+            'datetime64' => static function (mixed $value) {
+                if ($value instanceof DateTimeInterface) {
+                    return $value->format('U.u');
+                }
+
+                if (is_string($value) || is_float($value) || is_int($value)) {
+                    return $value;
+                }
+
+                throw UnsupportedParamValue::type($value);
+            },
 
             'Dynamic' => self::noopConverter(),
             'Variant' => self::noopConverter(),
@@ -232,7 +242,7 @@ public function get(Type|string $type): Closure
 
         $typeName  = strtolower($typeName);
         $converter = $this->registry[$typeName] ?? null;
-        if ($converter !== null && in_array($typeName, self::$caseInsensitiveTypes, true)) {
+        if ($converter !== null && in_array($typeName, self::CaseInsensitiveTypes, true)) {
             return $converter;
         }
 
@@ -271,17 +281,32 @@ private static function decimalConverter(): Closure
 
     private static function dateConverter(): Closure
     {
-        return static fn (DateTimeInterface|string|int|float $value) => $value instanceof DateTimeInterface
-            // We cannot convert to timestamp yet https://github.com/ClickHouse/ClickHouse/issues/75217
-            ? $value->format('Y-m-d')
-            : $value;
+        return static function (mixed $value) {
+            if ($value instanceof DateTimeInterface) {
+                return $value->format('Y-m-d');
+            }
+
+            if (is_string($value) || is_float($value) || is_int($value)) {
+                return $value;
+            }
+
+            throw UnsupportedParamValue::type($value);
+        };
     }
 
     private static function dateTimeConverter(): Closure
     {
-        return static fn (DateTimeInterface|string|int|float $value) => $value instanceof DateTimeInterface
-            ? $value->getTimestamp()
-            : $value;
+        return static function (mixed $value) {
+            if ($value instanceof DateTimeInterface) {
+                return $value->getTimestamp();
+            }
+
+            if (is_string($value) || is_float($value) || is_int($value)) {
+                return $value;
+            }
+
+            throw UnsupportedParamValue::type($value);
+        };
     }
 
     private static function dateIntervalConverter(): Closure
diff --git a/tests/Param/ParamValueConverterRegistryTest.php b/tests/Param/ParamValueConverterRegistryTest.php
index d7a7480..7395ba4 100644
--- a/tests/Param/ParamValueConverterRegistryTest.php
+++ b/tests/Param/ParamValueConverterRegistryTest.php
@@ -159,7 +159,13 @@ public static function providerConvert(): Generator
         yield 'Date' => ['Date', '2023-02-01', '2023-02-01'];
         yield 'Date (datetime)' => ['Date', new DateTimeImmutable('2023-02-01'), '2023-02-01'];
         yield 'Date32' => ['Date32', new DateTimeImmutable('2023-02-01'), '2023-02-01'];
-        yield 'DateTime' => ['DateTime', new DateTimeImmutable('2023-02-01 01:02:03'), '2023-02-01 01:02:03'];
+        yield 'DateTime (string)' => ['DateTime', '2023-02-01 01:02:03', '2023-02-01 01:02:03'];
+        yield 'DateTime (datetime)' => [
+            'DateTime',
+            new DateTimeImmutable('2023-02-01 01:02:03'),
+            '2023-02-01 01:02:03',
+        ];
+
         yield 'DateTime32' => ['DateTime32', new DateTimeImmutable('2023-02-01 01:02:03'), '2023-02-01 01:02:03'];
         yield 'DateTime64(3)' => [
             'DateTime64(3)',