Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest 1.6.0 breaks support for streaming large JSON resultsets #234

Open
tobia opened this issue Jan 29, 2025 · 0 comments
Open

Newest 1.6.0 breaks support for streaming large JSON resultsets #234

tobia opened this issue Jan 29, 2025 · 0 comments

Comments

@tobia
Copy link

tobia commented Jan 29, 2025

Up until version 1.5.3 we were using Client::streamRead() in order to read very large JSON resultsets (hundreds of MB) which would crash PHP if you attempted to json_decode() them.

This no longer works in 1.6.0, because now it always calls json_decode() behind the scenes, even when using streamRead()

This is because Client::streamRead() calls Transport\Http::streamRead() which calls Transport\Http::streaming() which creates a Statement and calls Statement::isError() which calls Statement::hasErrorClickhouse() which now does a full json_decode() of the response whenever the response is of JSON type.

Could you please remove this additional JSON decoding inside hasErrorClickhouse() or provide an option to turn it off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant