Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add Stairs.cummax #89

Open
venaturum opened this issue Sep 11, 2021 · 0 comments
Open

ENH: Add Stairs.cummax #89

venaturum opened this issue Sep 11, 2021 · 0 comments
Labels
beginner difficulty level enhancement New feature or request low priority

Comments

@venaturum
Copy link
Collaborator

venaturum commented Sep 11, 2021

Describe the solution you'd like

See analogous function in pandas https://pandas.pydata.org/docs/reference/api/pandas.Series.cummax.html

Requires skipna parameter. returns new Stairs instance with same initial_value and same value of "closed" property.

Functionality should be straightforward by applying pandas.Series.cummax to Stairs._data["value"] and using Stairs._new

The result will be a monotonically increasing step function

Additional context

https://www.staircase.dev/en/latest/development/guide/internals.html

@venaturum venaturum added beginner difficulty level enhancement New feature or request low priority labels Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner difficulty level enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant