Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of changelog.json #5

Open
AlexCPU opened this issue Jul 11, 2020 · 3 comments
Open

Limit size of changelog.json #5

AlexCPU opened this issue Jul 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@AlexCPU
Copy link
Contributor

AlexCPU commented Jul 11, 2020

When starting a new instance with no previously downloaded assets, the changelog.json lists every single image that has been downloaded. This causes changelog.html to contain 1.1GB of images when loaded into a browser. This feels like a bad idea!

Propose that if latestVersion.txt is blank/doesn't exist (i.e. this is the first run), that we generate an empty changelog.json, such that next time there are changes, these are the first to be captured.

@AlexCPU AlexCPU added the enhancement New feature or request label Jul 11, 2020
@AlexCPU
Copy link
Contributor Author

AlexCPU commented Jul 11, 2020

Also, we should limit the number of entries in the changelog.json so it doesn't get unwieldy over time. Seeing how this functionality is mostly used by people checking on names or paths of new assets, the last 10 updates would be my proposal

@ineffyble
Copy link
Member

@AlexCPU Is this still outstanding?

@AlexCPU
Copy link
Contributor Author

AlexCPU commented Apr 2, 2021

Yep, everything above is still true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants