Django Storages

[paribaker]

When using django-storages it seems MEDIA_URL does not take effect, I believe it can be removed from the if statement.

I also noticed that we are setting a custom domain but that is not used anywhere, it seems custom domain is only useful when using a CDN like cloudfront AWS_S3_CUSTOM_DOMAIN this variable will only take effect if we remove custom_domain in storages.py HOWEVER this would disable the auth query string by default (unless the Cloudfront variables are added).

It seems like there is another variable that could be set for custom domains

AWS_S3_ENDPOINT_URL

this can be useful when your bucket is not in the default us regions

AWS_S3_REGION_NAME = config("AWS_S3_REGION_NAME")
AWS_S3_ENDPOINT_URL = f"https://s3/.{AWS_S3_REGION_NAME}.amazonaws.com"

I am not sure what determines the region in when not specifically calling it out.

I propose we change the configs to look like this:

if config("USE_AWS_STORAGE", cast=bool, default=False):
    AWS_ACCESS_KEY_ID = config("AWS_ACCESS_KEY_ID")
    AWS_STORAGE_BUCKET_NAME = config("AWS_STORAGE_BUCKET_NAME")
    AWS_SECRET_ACCESS_KEY = config("AWS_SECRET_ACCESS_KEY")

    AWS_LOCATION = config("AWS_LOCATION")  # production, staging, etc
    AWS_S3_REGION_NAME = config("AWS_S3_REGION_NAME")
    AWS_S3_ENDPOINT_URL =  f"https://s3/.{AWS_S3_REGION_NAME}.amazonaws.com"
    AWS_S3_ADDRESSING_STYLE = 'virtual'

    # Default file storage is private
    PRIVATE_MEDIAFILES_LOCATION = AWS_LOCATION + "/media"
    DEFAULT_FILE_STORAGE = "<APP_NAME>.utils.storages.PrivateMediaStorage"
    COLLECTFAST_STRATEGY = "collectfast.strategies.boto3.Boto3Strategy"