Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

Adapter\ClientSideValidationAdapter->rules has a misleading signiture #26

Open
Silic0nS0ldier opened this issue Feb 17, 2019 · 0 comments

Comments

@Silic0nS0ldier
Copy link
Member

The first argument, $format is at conflict with the second, $stringEncode.

This leads to scenarios where you have code like

$validators->rules('json', false);

or

$validators->rules('json', true);

which makes it very difficult to predict what the output will be. In fact, this is happening within UF Core right now, where the latter example is used.

There is no way this problem could be addressed without a semver major change, as any action would result in potentially changed outputs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant