Fix sliders on first boot, carret not clearing, choice button fade out, etc. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drojf
force-pushed
the
f-fix-first-boot-sliders
branch
from
41e7b22 to
11bdd17
Compare
drojf
changed the title
- Fix bug where changing sprite type during lipsync animation causes sprtie to remain as console sprite, but squished in size due to console texture overwriting OG or Mangagamer texture - This bug persist until the affected sprite is next changed
drojf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug (in rei, but probably also in all chapters) where the first time you start the game, the sliders will have the wrong values (they will look like they're at 100% when they're actually at 50% or 75% for voice).
If you visited the config menu the first time you boot the game, this might make you want to reset them all to 50%. since they look too high.
This appears to be because on first boot, the various volumes/opacity etc. are not synced with their flags. I just changed the sliders to take the values directly from the flags, rather than the variables.
Haven't done much testing on this, am worried this might break the sliders.
Note that I simulated "first boot" by deleting the
global.datfile, unsure if there is some defaultglobal.datfile that comes with the game, or if it is generated the first time you boot the game.See 07th-mod/higurashi-rei#13 (comment)