Add quotes for env variables access

0xPolygon · Mar 18, 2024 · 209f75e · 209f75e
1 parent efb9e3e
commit 209f75e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml
@@ -65,7 +65,7 @@ jobs:
         uses: aws-actions/configure-aws-credentials@v1
         with:
           aws-region: eu-west-1
-          role-to-assume: arn:aws:iam::$ACCOUNT_NUMBER:role/static-$DEPLOY_ENV-GithubActionsRole
+          role-to-assume: "arn:aws:iam::$ACCOUNT_NUMBER:role/static-$DEPLOY_ENV-GithubActionsRole"
           role-session-name: GithubActionsSession
 
       - name: Login to Amazon ECR
@@ -77,7 +77,7 @@ jobs:
         env:
           ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
           IMAGE_TAG: ${{ github.sha }}
-          ECR_REPOSITORY: static-$DEPLOY_ENV-ecr
+          ECR_REPOSITORY: "static-$DEPLOY_ENV-ecr"
         run: |
           docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
@@ -92,13 +92,13 @@ jobs:
         uses: aws-actions/amazon-ecs-render-task-definition@v1
         with:
           task-definition: "${{ env.TASKDEF_FILE }}"
-          container-name: static-$DEPLOY_ENV
+          container-name: "static-$DEPLOY_ENV"
           image: ${{ steps.build-image.outputs.image }}
 
       - name: Deploy Amazon ECS task definition
         uses: aws-actions/amazon-ecs-deploy-task-definition@v1
         with:
           task-definition: ${{ steps.task-def.outputs.task-definition }}
-          service: static-$DEPLOY_ENV-ecs-service
-          cluster: static-$DEPLOY_ENV-ecs-cluster
+          service: "static-$DEPLOY_ENV-ecs-service"
+          cluster: "static-$DEPLOY_ENV-ecs-cluster"
           wait-for-service-stability: true