Add "give kredits" button to contributor profiles #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default attributes are only set correctly when either none or all attributes are handed to the component
Just contributor ID, kind, and amount for now.
galfert
approved these changes
Dec 13, 2019
| Object.keys(this.defaultAttr).forEach(a => { | ||
| if (typeof this.attributes[a] === 'undefined') { | ||
| this.attributes[a] = this.defaultAttr[a]; | ||
| } |
There was a problem hiding this comment.
Instead of merging attributes manually, you can use Ember's assign method to replace the whole if-else block.
import { assign } from '@ember/polyfills';
...
this.set('attributes', assign({}, this.defaultAttr, this.attributes));
Co-authored-by: Garret Alfert <alfert@wevelop.de>
raucao
force-pushed
the
feature/add_contribution_with_params
branch
from
9e5af8d to
3f4cc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes support for query params for submitting new contributions (contributor ID, kind, amount).
closes #172
refs #40