feat!: pydantic v2 support [APE-1412] #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
antazoey
commented
Sep 25, 2023
| class TraceMemory(BaseModel): | ||
| __root__: List[HexBytes] = [] | ||
| class TraceMemory(RootModel[List[HexBytes]]): | ||
| root: List[HexBytes] = [] |
There was a problem hiding this comment.
I still defined root here because that was the only way to make it default to empty list when it got used in other models.
antazoey
commented
Sep 25, 2023
| @@ -34,7 +34,7 @@ | |||
| def test_parity(name): | |||
| assert name in EXPECTED_OUTPUT_MAP, f"Missing expected output set for '{name}'." | |||
| path = DATA_PATH / f"{name}.json" | |||
| traces = ParityTraceList.parse_file(path) | |||
| traces = ParityTraceList.model_validate_json(path.read_text()) | |||
There was a problem hiding this comment.
I love that Pydantic V2 avoids clobbering the model's namespace by prefixing all their methods with model_.
One might think that is a bad design to have methods with those types of names, but honestly, it is bad design to clobber namespaces. Props to Pydantic v2.
antazoey
force-pushed
the
feat/pydantic-v2
branch
from
90aa4c7 to
ec12a08
Compare
NotPeopling2day
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Upgrade to pydantic v2
How I did it
follow the migration guide
How to verify it
Checklist