refactor: remove cniTypesCurr.Result dependency in InterfaceInfo #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
2 times, most recently
from
8ce36c4 to
f0b55c1
Compare
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
4 times, most recently
from
0e2b811 to
c04f56a
Compare
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
4 times, most recently
from
3f2f41e to
f1aa18d
Compare
nddq
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
from
f1aa18d to
69c7338
Compare
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
3 times, most recently
from
ec1909a to
49106a2
Compare
nddq
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
from
49106a2 to
8ed6260
Compare
nddq
approved these changes
Nov 13, 2023
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
from
8ed6260 to
6be9cd4
Compare
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
from
6be9cd4 to
2bb9810
Compare
vipul-21
reviewed
Nov 13, 2023
vipul-21
approved these changes
Nov 13, 2023
|
/azp run CNI Load Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
load tests passed https://msazure.visualstudio.com/One/_build/results?buildId=82852995&view=results |
jaer-tsun
force-pushed
the
tsch/replaceCniTypesInInterfaceInfo
branch
from
2bb9810 to
dbfbb0a
Compare
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
* refactor: remove cniTypesCurr.Result dependency in InterfaceInfo * update baremetal * add interface in cni result conversion func * update gateway route --------- Co-authored-by: Jaeryn <tsch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
removing cniTypesCurr.Result dependency in InterfaceInfo
adding scope link for swiftv2 gateway route
Issue Fixed:
Requirements:
Notes: