-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle async delete in stateless cni #2967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzad-mir
force-pushed
the
statelesCNI-asynchdelete
branch
3 times, most recently
from
August 28, 2024 19:23
c75da1b
to
ccaa383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add any UTs for this?
rbtr
reviewed
Aug 28, 2024
behzad-mir
force-pushed
the
statelesCNI-asynchdelete
branch
6 times, most recently
from
September 12, 2024 00:05
c456ffa
to
5aed0db
Compare
tamilmani1989
changed the title
fix: Stateles cni asynchdelete
fix: Handle async delete in stateless cni
Sep 12, 2024
tamilmani1989
added
cns
Related to CNS.
cni
Related to CNI.
ci
Infra or tooling.
labels
Sep 12, 2024
behzad-mir
force-pushed
the
statelesCNI-asynchdelete
branch
5 times, most recently
from
September 17, 2024 22:56
36ac33f
to
2d55822
Compare
tamilmani1989
requested changes
Sep 18, 2024
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Signed-off-by: Behzad Mirkhanzadeh <b.mirkhanzadeh@gmail.com>
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Signed-off-by: Behzad Mirkhanzadeh <b.mirkhanzadeh@gmail.com>
behzad-mir
force-pushed
the
statelesCNI-asynchdelete
branch
from
September 20, 2024 16:27
a8cab91
to
98f6163
Compare
rbtr
reviewed
Sep 20, 2024
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Signed-off-by: Behzad Mirkhanzadeh <b.mirkhanzadeh@gmail.com>
rbtr
previously approved these changes
Sep 20, 2024
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Sep 20, 2024
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fixed:
This is an attempt to fix the HNS endpoint leak by stateless CNI when the aynch delete is enabled.
CNS needs to delete the associate HNS endpoint ids upon releasing IPs in asynch delete mode.
Notes: