Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle async delete in stateless cni #2967

Merged
merged 22 commits into from
Sep 21, 2024
Merged

Conversation

behzad-mir
Copy link
Contributor

Issue Fixed:

This is an attempt to fix the HNS endpoint leak by stateless CNI when the aynch delete is enabled.
CNS needs to delete the associate HNS endpoint ids upon releasing IPs in asynch delete mode.

Notes:

@behzad-mir behzad-mir requested review from a team as code owners August 28, 2024 16:45
@behzad-mir behzad-mir force-pushed the statelesCNI-asynchdelete branch 3 times, most recently from c75da1b to ccaa383 Compare August 28, 2024 19:23
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add any UTs for this?

cni/network/network.go Outdated Show resolved Hide resolved
cni/network/network.go Outdated Show resolved Hide resolved
cni/network/network.go Outdated Show resolved Hide resolved
cni/network/network.go Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
@behzad-mir behzad-mir force-pushed the statelesCNI-asynchdelete branch 6 times, most recently from c456ffa to 5aed0db Compare September 12, 2024 00:05
cni/network/network.go Show resolved Hide resolved
cns/client/client.go Outdated Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/hnsclient/hnsclient_windows.go Outdated Show resolved Hide resolved
.pipelines/pipeline.yaml Outdated Show resolved Hide resolved
@tamilmani1989 tamilmani1989 changed the title fix: Stateles cni asynchdelete fix: Handle async delete in stateless cni Sep 12, 2024
@tamilmani1989 tamilmani1989 added cns Related to CNS. cni Related to CNI. ci Infra or tooling. labels Sep 12, 2024
cni/network/network.go Outdated Show resolved Hide resolved
cni/network/network.go Outdated Show resolved Hide resolved
cni/network/network.go Outdated Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/hnsclient/hnsclient_windows.go Outdated Show resolved Hide resolved
@behzad-mir behzad-mir force-pushed the statelesCNI-asynchdelete branch 5 times, most recently from 36ac33f to 2d55822 Compare September 17, 2024 22:56
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/fsnotify/fsnotify.go Outdated Show resolved Hide resolved
cns/types/codes.go Outdated Show resolved Hide resolved
behzad-mir and others added 5 commits September 20, 2024 09:27
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Behzad Mirkhanzadeh <b.mirkhanzadeh@gmail.com>
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Behzad Mirkhanzadeh <b.mirkhanzadeh@gmail.com>
@behzad-mir behzad-mir force-pushed the statelesCNI-asynchdelete branch from a8cab91 to 98f6163 Compare September 20, 2024 16:27
@behzad-mir behzad-mir requested a review from rbtr September 20, 2024 17:33
@behzad-mir behzad-mir requested a review from rbtr September 20, 2024 17:43
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Behzad Mirkhanzadeh <b.mirkhanzadeh@gmail.com>
rbtr
rbtr previously approved these changes Sep 20, 2024
@rbtr
Copy link
Contributor

rbtr commented Sep 20, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@behzad-mir
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@behzad-mir behzad-mir added this pull request to the merge queue Sep 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2024
@rbtr rbtr added this pull request to the merge queue Sep 21, 2024
Merged via the queue into master with commit a9fccfa Sep 21, 2024
14 checks passed
@rbtr rbtr deleted the statelesCNI-asynchdelete branch September 21, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. cni Related to CNI. cns Related to CNS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants