ci: add delay after link creation for test add remove static arp #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
force-pushed
the
alew/remove-arp-ut
branch
3 times, most recently
from
f214ec7 to
117facf
Compare
QxBytes
force-pushed
the
alew/remove-arp-ut
branch
from
ea58db9 to
e2f6bf2
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
changed the title
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
tamilmani1989
approved these changes
Sep 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Linux AddRemoveStaticArp is flaky. It creates the static arp with no errors, but when we try to delete it, we get a response that the file is not found. This logs as an error but the pipeline retries 3 times, so this typically goes unnoticed. If the purpose of the deletion is to ensure the arp entry is deleted, this message likely indicates the arp entry is no longer present.
Observed behavior is that the arp entry is added to the arp table, but then is automatically and immediately deleted a fraction of a second later. When using an existing link, or a link that has been up for some time (> 1 second), the arp entry sticks around.
Theory as to why this happens:
The solution is adding a delay after creating the link.
Issue Fixed:
Requirements:
Notes:
Relevant pipeline examples:
Running the test 100 times, no error detected with fix: https://msazure.visualstudio.com/One/_build/results?buildId=101831502&view=logs&j=792982d5-3bb1-5d82-222e-228148b73448&t=fe31bb4d-d8c6-5505-3ab3-3c9a2560c42b&l=959Running the test 10 times, no error detected with fix: https://msazure.visualstudio.com/One/_build/results?buildId=101952522&view=logs&j=792982d5-3bb1-5d82-222e-228148b73448&t=fe31bb4d-d8c6-5505-3ab3-3c9a2560c42b&l=962
Example error: https://msazure.visualstudio.com/One/_build/results?buildId=101778154&view=logs&j=792982d5-3bb1-5d82-222e-228148b73448&t=fe31bb4d-d8c6-5505-3ab3-3c9a2560c42b&l=1091