Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase goldpinger replicas from 4 to 8 and add topology constraints #3376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Jan 29, 2025

Reason for Change:

Attempts to fix this issue in our pipelines: https://msazure.visualstudio.com/One/_build/results?buildId=113599589&view=logs&j=b1429627-982b-5d7c-f874-2297f1590463&t=f4ed6e9d-3ea8-54bd-90c0-ce2d41a370dc

It looks like there is a possibility that one node becomes unbalanced (ex: both metrics pods, gateway keepers etc. all land on the same node), and so new pods are scheduled all on the other node to balance resources. This PR increases the number of replicas such that it is more likely that at least two pods land on each node (which is a hard requirement in the test). It also adds a topology constraint to encourage pods to distribute themselves on the nodes.

Issue Fixed:

Requirements:

Notes:
Successful runs:
https://msazure.visualstudio.com/One/_build/results?buildId=113216481
https://msazure.visualstudio.com/One/_build/results?buildId=113216663
https://msazure.visualstudio.com/One/_build/results?buildId=113217222
https://msazure.visualstudio.com/One/_build/results?buildId=113258554
https://msazure.visualstudio.com/One/_build/results?buildId=113266372

@QxBytes QxBytes added the ci Infra or tooling. label Jan 29, 2025
@QxBytes QxBytes self-assigned this Jan 29, 2025
@QxBytes
Copy link
Contributor Author

QxBytes commented Jan 30, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes marked this pull request as ready for review January 30, 2025 01:03
@QxBytes QxBytes requested a review from a team as a code owner January 30, 2025 01:03
@QxBytes QxBytes requested a review from rajvinar January 30, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant