Skip to content

Commit

Permalink
Merge branch 'release/1.5.6' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
firestar300 committed Sep 25, 2024
2 parents 734ee8e + 2b2574f commit 26da0d8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 1.5.6 - 2024-09-25

- Add condition to hidden class name for the modal component.

## 1.5.5 - 2024-07-31

- Add `onTabChange` option callback for Tabs component
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@beapi/be-a11y",
"version": "1.5.5",
"version": "1.5.6",
"type": "module",
"description": "Collection of usefull accessible components",
"repository": {
Expand Down
4 changes: 3 additions & 1 deletion src/classes/Modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ class Modal extends AbstractDomElement {
el.id = this.id
}

el.classList.add(closedClassName)
if (el.hasAttribute('aria-hidden') && el.getAttribute('aria-hidden') === 'true') {
el.classList.add(closedClassName)
}

// Set aria-labelledby attribute
if (labelSelector && el.querySelector(labelSelector)) {
Expand Down

0 comments on commit 26da0d8

Please sign in to comment.