Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/from netcdf fast #993

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Conversation

NicolasColombi
Copy link
Collaborator

@NicolasColombi NicolasColombi commented Jan 16, 2025

Changes proposed in this PR:

This PR adds a method to import tropical cyclones tracks from an open source tc model called FAST.

  • from_FAST(): Import model output in netcdf format, restructure it, compute missing central pressure and radious of maximal wind
  • define_tc_category_FAST(): define tropical cyclone category based on Saffir-Simpson hurricane wind scale
  • test_from_FAST()
  • test_define_tc_category_FAST()

PR Author Checklist

PR Reviewer Checklist

@peanutfun
Copy link
Member

I haven't reviewed the changes, but I looked at this PR because it sounded like you implemented a faster way of reading NetCDF. It might be worthwhile to consider disobeying the naming scheme and uppercasing "FAST" in the method names (i.e., from_FAST) to clarify that it does not mean "quick" 😅

@NicolasColombi NicolasColombi marked this pull request as ready for review January 27, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants